Merge 0a51a865d3 into 6cce8a8bc4

Co-authored-by: Vendicated <vendicated@riseup.net>

src/plugins/appleMusic.desktop/index.tsx

@@ -24,7 +24,7 @@ interface ActivityButton {
 }
 
 interface Activity {
-    state: string;
+    state?: string;
     details?: string;
     timestamps?: {
         start?: number;
@@ -52,8 +52,8 @@ const enum ActivityFlag {
 
 export interface TrackData {
     name: string;
-    album: string;
-    artist: string;
+    album?: string;
+    artist?: string;
 
     appleMusicLink?: string;
     songLink?: string;
@@ -61,8 +61,8 @@ export interface TrackData {
     albumArtwork?: string;
     artistArtwork?: string;
 
-    playerPosition: number;
-    duration: number;
+    playerPosition?: number;
+    duration?: number;
 }
 
 const enum AssetImageType {
@@ -155,8 +155,8 @@ const settings = definePluginSettings({
 function customFormat(formatStr: string, data: TrackData) {
     return formatStr
         .replaceAll("{name}", data.name)
-        .replaceAll("{album}", data.album)
-        .replaceAll("{artist}", data.artist);
+        .replaceAll("{album}", data.album ?? "")
+        .replaceAll("{artist}", data.artist ?? "");
 }
 
 function getImageAsset(type: AssetImageType, data: TrackData) {
@@ -212,14 +212,16 @@ export default definePlugin({
 
         const assets: ActivityAssets = {};
 
+        const isRadio = Number.isNaN(trackData.duration) && (trackData.playerPosition === 0);
+
         if (settings.store.largeImageType !== AssetImageType.Disabled) {
             assets.large_image = largeImageAsset;
-            assets.large_text = customFormat(settings.store.largeTextString, trackData);
+            if (!isRadio) assets.large_text = customFormat(settings.store.largeTextString, trackData);
         }
 
         if (settings.store.smallImageType !== AssetImageType.Disabled) {
             assets.small_image = smallImageAsset;
-            assets.small_text = customFormat(settings.store.smallTextString, trackData);
+            if (!isRadio) assets.small_text = customFormat(settings.store.smallTextString, trackData);
         }
 
         const buttons: ActivityButton[] = [];
@@ -243,17 +245,17 @@ export default definePlugin({
 
             name: customFormat(settings.store.nameString, trackData),
             details: customFormat(settings.store.detailsString, trackData),
-            state: customFormat(settings.store.stateString, trackData),
+            state: isRadio ? undefined : customFormat(settings.store.stateString, trackData),
 
-            timestamps: (settings.store.enableTimestamps ? {
+            timestamps: (trackData.playerPosition && trackData.duration && settings.store.enableTimestamps) ? {
                 start: Date.now() - (trackData.playerPosition * 1000),
                 end: Date.now() - (trackData.playerPosition * 1000) + (trackData.duration * 1000),
-            } : undefined),
+            } : undefined,
 
             assets,
 
-            buttons: buttons.length ? buttons.map(v => v.label) : undefined,
-            metadata: { button_urls: buttons.map(v => v.url) || undefined, },
+            buttons: !isRadio && buttons.length ? buttons.map(v => v.label) : undefined,
+            metadata: !isRadio && buttons.length ? { button_urls: buttons.map(v => v.url) } : undefined,
 
             type: settings.store.activityType,
             flags: ActivityFlag.INSTANCE,

src/plugins/betterSettings/PluginsSubmenu.tsx

@@ -0,0 +1,68 @@
+/*
+ * Vencord, a Discord client mod
+ * Copyright (c) 2024 Vendicated and contributors
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+import { openPluginModal } from "@components/PluginSettings/PluginModal";
+import { isObjectEmpty } from "@utils/misc";
+import { Alerts, i18n, Menu, useMemo, useState } from "@webpack/common";
+
+import Plugins from "~plugins";
+
+function onRestartNeeded() {
+    Alerts.show({
+        title: "Restart required",
+        body: <p>You have changed settings that require a restart.</p>,
+        confirmText: "Restart now",
+        cancelText: "Later!",
+        onConfirm: () => location.reload()
+    });
+}
+
+export default function PluginsSubmenu() {
+    const sortedPlugins = useMemo(() => Object.values(Plugins)
+        .sort((a, b) => a.name.localeCompare(b.name)), []);
+    const [query, setQuery] = useState("");
+
+    const search = query.toLowerCase();
+    const include = (p: typeof Plugins[keyof typeof Plugins]) => (
+        Vencord.Plugins.isPluginEnabled(p.name)
+        && p.options && !isObjectEmpty(p.options)
+        && (
+            p.name.toLowerCase().includes(search)
+            || p.description.toLowerCase().includes(search)
+            || p.tags?.some(t => t.toLowerCase().includes(search))
+        )
+    );
+
+    const plugins = sortedPlugins.filter(include);
+
+    return (
+        <>
+            <Menu.MenuControlItem
+                id="vc-plugins-search"
+                control={(props, ref) => (
+                    <Menu.MenuSearchControl
+                        {...props}
+                        query={query}
+                        onChange={setQuery}
+                        ref={ref}
+                        placeholder={i18n.Messages.SEARCH}
+                    />
+                )}
+            />
+
+            {!!plugins.length && <Menu.MenuSeparator />}
+
+            {plugins.map(p => (
+                <Menu.MenuItem
+                    key={p.name}
+                    id={p.name}
+                    label={p.name}
+                    action={() => openPluginModal(p, onRestartNeeded)}
+                />
+            ))}
+        </>
+    );
+}

src/plugins/betterSettings/index.tsx

@@ -13,6 +13,8 @@ import { waitFor } from "@webpack";
 import { ComponentDispatch, FocusLock, i18n, Menu, useEffect, useRef } from "@webpack/common";
 import type { HTMLAttributes, ReactElement } from "react";
 
+import PluginsSubmenu from "./PluginsSubmenu";
+
 type SettingsEntry = { section: string, label: string; };
 
 const cl = classNameFactory("");
@@ -118,13 +120,21 @@ export default definePlugin({
         },
         { // Settings cog context menu
             find: "Messages.USER_SETTINGS_ACTIONS_MENU_LABEL",
-            replacement: {
-                match: /(EXPERIMENTS:.+?)(\(0,\i.\i\)\(\))(?=\.filter\(\i=>\{let\{section:\i\}=)/,
-                replace: "$1$self.wrapMenu($2)"
-            }
-        }
+            replacement: [
+                {
+                    match: /(EXPERIMENTS:.+?)(\(0,\i.\i\)\(\))(?=\.filter\(\i=>\{let\{section:\i\}=)/,
+                    replace: "$1$self.wrapMenu($2)"
+                },
+                {
+                    match: /case \i\.\i\.DEVELOPER_OPTIONS:return \i;/,
+                    replace: "$&case 'VencordPlugins':return $self.PluginsSubmenu();"
+                }
+            ]
+        },
     ],
 
+    PluginsSubmenu,
+
     // This is the very outer layer of the entire ui, so we can't wrap this in an ErrorBoundary
     // without possibly also catching unrelated errors of children.
     //

src/plugins/consoleJanitor/index.ts

@@ -126,7 +126,7 @@ export default definePlugin({
             }
         },
         {
-            find: '"Handling ping: "',
+            find: '"_handleLocalVideoDisabled: ',
             predicate: () => settings.store.disableNoisyLoggers,
             replacement: {
                 match: /new \i\.\i\("RTCConnection\("\.concat.+?\)\)(?=,)/,

src/plugins/editUsers/data.ts

@@ -0,0 +1,42 @@
+/*
+ * Vencord, a Discord client mod
+ * Copyright (c) 2024 Vendicated and contributors
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+import { definePluginSettings } from "@api/Settings";
+
+export const enum OverrideFlags {
+    None = 0,
+    PreferServerNicks = 1 << 0,
+    DisableNicks = 1 << 1,
+    KeepServerAvatar = 1 << 2,
+    DisableServerAvatars = 1 << 3,
+    KeepServerBanner = 1 << 4,
+    DisableServerBanners = 1 << 5,
+}
+
+export interface UserOverride {
+    username: string;
+    avatarUrl: string;
+    bannerUrl: string;
+    pronouns: string;
+    flags: OverrideFlags;
+}
+
+export const emptyOverride: UserOverride = Object.freeze({
+    username: "",
+    avatarUrl: "",
+    bannerUrl: "",
+    pronouns: "",
+    flags: OverrideFlags.None,
+});
+
+export const settings = definePluginSettings({})
+    .withPrivateSettings<{
+        users?: Record<string, UserOverride>;
+    }>();
+
+export const getUserOverride = (userId: string) => settings.store.users?.[userId] ?? emptyOverride;
+
+export const hasFlag = (field: OverrideFlags, flag: OverrideFlags) => (field & flag) === flag;

src/plugins/editUsers/index.tsx

@@ -0,0 +1,125 @@
+/*
+ * Vencord, a Discord client mod
+ * Copyright (c) 2024 Vendicated and contributors
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+import "./styles.css";
+
+import { Devs } from "@utils/constants";
+import definePlugin from "@utils/types";
+import { Menu } from "@webpack/common";
+import { User } from "discord-types/general";
+
+import { getUserOverride, hasFlag, OverrideFlags, settings } from "./data";
+import { openUserEditModal } from "./modal";
+
+export default definePlugin({
+    name: "EditUsers",
+    description: "Edit users",
+    authors: [Devs.Ven],
+
+    settings,
+
+    contextMenus: {
+        "user-context"(children, { user }: { user?: User; }) {
+            if (!user) return;
+
+            children.push(
+                <Menu.MenuItem
+                    id="vc-edit-user"
+                    label="Edit User"
+                    action={() => openUserEditModal(user)}
+                />
+            );
+        }
+    },
+
+    patches: [
+        {
+            find: ",getUserTag:",
+            replacement: {
+                match: /if\(\i\((\i)\.global_name\)\)return(?=.{0,100}return"\?\?\?")/,
+                replace: "const vcEuName=$self.getUsername($1);if(vcEuName)return vcEuName;$&"
+            }
+        },
+        {
+            find: "=this.guildMemberAvatars[",
+            replacement: [
+                {
+                    match: /&&null!=this\.guildMemberAvatars\[\i\]/,
+                    replace: "$& && !$self.shouldIgnoreGuildAvatar(this)"
+                },
+                {
+                    match: /(?<=null!=(\i))\?(\i\.\i\.getGuildMemberAvatarURLSimple.+?):(?=\i\.\i\.getUserAvatarURL\(this)/,
+                    replace: "&& this.hasAvatarForGuild?.($1) ? $2 : $self.getAvatarUrl(this)||"
+                }
+            ]
+        },
+        {
+            find: "this.isUsingGuildMemberBanner()",
+            replacement: [
+                {
+                    match: /:\i\.banner\)!=null/,
+                    replace: "$& && !$self.shouldIgnoreGuildBanner(this.userId)"
+                },
+                {
+                    match: /(?<=:).{0,10}\(\{id:this\.userId,banner/,
+                    replace: "$self.getBannerUrl(this.userId)||$&"
+                },
+                {
+                    match: /isUsingGuildMemberPronouns\(\)\{/,
+                    replace:
+                        "set pronouns(v){this._vcPronouns=v}" +
+                        "get pronouns(){return $self.getPronouns(this.userId)||this._vcPronouns}" +
+                        "isUsingGuildMemberPronouns(){"
+                },
+                {
+                    match: /\i\(this,"pronouns",void 0\),/,
+                    replace: ""
+                }
+            ]
+        },
+        {
+            find: '"GuildMemberStore"',
+            replacement: {
+                match: /getNick\(\i,(\i)\)\{/,
+                replace: "$& if ($self.shouldIgnoreNick($1)) return null;"
+            }
+        }
+    ],
+
+    getUsername: (user: User) => getUserOverride(user.id).username,
+    getAvatarUrl: (user: User) => getUserOverride(user.id).avatarUrl,
+    getBannerUrl: (userId: string) => getUserOverride(userId).bannerUrl,
+    getPronouns: (userId: string) => getUserOverride(userId).pronouns,
+
+    shouldIgnoreGuildAvatar(user: User) {
+        const { avatarUrl, flags } = getUserOverride(user.id);
+
+        if (avatarUrl && !hasFlag(flags, OverrideFlags.KeepServerAvatar))
+            return true;
+
+        return hasFlag(flags, OverrideFlags.DisableServerAvatars);
+    },
+
+    shouldIgnoreGuildBanner(userId: string) {
+        const { bannerUrl, flags } = getUserOverride(userId);
+
+        if (bannerUrl && !hasFlag(flags, OverrideFlags.KeepServerBanner))
+            return true;
+
+        return hasFlag(flags, OverrideFlags.DisableServerBanners);
+    },
+
+    shouldIgnoreNick(userId?: string) {
+        if (!userId) return false;
+
+        const { username, flags } = getUserOverride(userId);
+
+        if (username && !hasFlag(flags, OverrideFlags.PreferServerNicks))
+            return true;
+
+        return hasFlag(flags, OverrideFlags.DisableNicks);
+    }
+});

src/plugins/editUsers/modal.tsx

@@ -0,0 +1,170 @@
+/*
+ * Vencord, a Discord client mod
+ * Copyright (c) 2024 Vendicated and contributors
+ * SPDX-License-Identifier: GPL-3.0-or-later
+ */
+
+import { classNameFactory } from "@api/Styles";
+import { Flex } from "@components/Flex";
+import { Margins } from "@utils/margins";
+import { ModalCloseButton, ModalContent, ModalFooter, ModalHeader, ModalProps, ModalRoot, ModalSize, openModal } from "@utils/modal";
+import { Button, DisplayProfileUtils, showToast, Switch, TabBar, Text, TextInput, Toasts, UsernameUtils, useState } from "@webpack/common";
+import { User } from "discord-types/general";
+import type { Dispatch, SetStateAction } from "react";
+
+import { emptyOverride, hasFlag, OverrideFlags, settings, UserOverride } from "./data";
+
+const cl = classNameFactory("vc-editUsers-");
+
+interface OverrideProps {
+    override: UserOverride;
+    setOverride: Dispatch<SetStateAction<UserOverride>>;
+}
+
+interface SettingsRowProps extends OverrideProps {
+    overrideKey: keyof Omit<UserOverride, "flags">;
+    name: string;
+    flagDisable: OverrideFlags;
+    flagPrefer: OverrideFlags;
+    placeholder: string;
+}
+
+function SettingsRow(props: SettingsRowProps) {
+    const { name, override, setOverride, overrideKey, placeholder, flagDisable, flagPrefer } = props;
+    const namePlural = name + "s";
+    const { flags } = override;
+
+    const toggleFlag = (on: boolean, flag: OverrideFlags) =>
+        on
+            ? flags | flag
+            : flags & ~flag;
+
+    return (
+        <>
+            <TextInput
+                className={Margins.bottom16}
+                value={override[overrideKey]}
+                onChange={v => setOverride(o => ({ ...o, [overrideKey]: v }))}
+                placeholder={placeholder}
+                autoFocus
+            />
+            <Switch
+                value={hasFlag(flags, flagDisable)}
+                onChange={v => setOverride(o => ({ ...o, flags: toggleFlag(v, flagDisable) }))}
+                note={`Will use the user's global ${name} (or your EditUser configured ${name}) over server specific ${namePlural}`}
+            >
+                Disable server specific {namePlural}
+            </Switch>
+            <Switch
+                value={hasFlag(flags, flagPrefer)}
+                onChange={v => setOverride(o => ({ ...o, flags: toggleFlag(v, flagPrefer) }))}
+                note={`Will use server specific ${namePlural} over the EditUser configured ${name}`}
+                hideBorder
+            >
+                Prefer server specific {namePlural}
+            </Switch>
+        </>
+    );
+}
+
+const Tabs = {
+    username: {
+        name: "Username",
+        flagDisable: OverrideFlags.DisableNicks,
+        flagPrefer: OverrideFlags.PreferServerNicks,
+        placeholder: (user: User) => UsernameUtils.getName(user),
+    },
+    avatarUrl: {
+        name: "Avatar",
+        flagDisable: OverrideFlags.DisableServerAvatars,
+        flagPrefer: OverrideFlags.KeepServerAvatar,
+        placeholder: (user: User) => user.getAvatarURL(),
+    },
+    bannerUrl: {
+        name: "Banner",
+        flagDisable: OverrideFlags.DisableServerBanners,
+        flagPrefer: OverrideFlags.KeepServerBanner,
+        placeholder: (user: User) => DisplayProfileUtils.getDisplayProfile(user.id)?.getBannerURL({ canAnimate: true, size: 64 }) ?? "",
+    },
+} as const;
+const TabKeys = Object.keys(Tabs) as (keyof typeof Tabs)[];
+
+function EditTabs({ user, override, setOverride }: { user: User; } & OverrideProps) {
+    const [currentTabName, setCurrentTabName] = useState(TabKeys[0]);
+
+    const currentTab = Tabs[currentTabName];
+
+    return (
+        <>
+            <TabBar
+                type="top"
+                look="brand"
+                className={cl("tabBar")}
+                selectedItem={currentTabName}
+                onItemSelect={setCurrentTabName}
+            >
+                {TabKeys.map(key => (
+                    <TabBar.Item
+                        id={key}
+                        key={key}
+                        className={cl("tab")}
+                    >
+                        {Tabs[key].name}
+                    </TabBar.Item>
+                ))}
+            </TabBar>
+
+            <SettingsRow
+                {...currentTab}
+                override={override}
+                overrideKey={currentTabName}
+                setOverride={setOverride}
+                placeholder={currentTab.placeholder(user)}
+            />
+        </>
+    );
+}
+
+function EditModal({ user, modalProps }: { user: User; modalProps: ModalProps; }) {
+    const [override, setOverride] = useState(() => ({ ...settings.store.users?.[user.id] ?? emptyOverride }));
+
+    return (
+        <ModalRoot {...modalProps} size={ModalSize.MEDIUM}>
+            <ModalHeader>
+                <Text variant="heading-lg/semibold" style={{ flexGrow: 1 }}>Edit User {user.username}</Text>
+                <ModalCloseButton onClick={modalProps.onClose} />
+            </ModalHeader>
+
+            <ModalContent>
+                <div className={cl("modal")}>
+                    <EditTabs user={user} override={override} setOverride={setOverride} />
+                </div>
+            </ModalContent>
+
+            <ModalFooter>
+                <Flex>
+                    <Button
+                        color={Button.Colors.RED}
+                        onClick={() => setOverride({ ...emptyOverride })}
+                    >
+                        Reset All
+                    </Button>
+                    <Button
+                        onClick={() => {
+                            const s = settings.store.users ??= {};
+                            s[user.id] = override;
+                            modalProps.onClose();
+                            showToast("Saved! Switch chats for changes to apply everywhere", Toasts.Type.SUCCESS, { position: Toasts.Position.BOTTOM });
+                        }}
+                    >
+                        Save
+                    </Button>
+                </Flex>
+            </ModalFooter>
+        </ModalRoot>
+    );
+}
+
+export function openUserEditModal(user: User) {
+    openModal(props => <EditModal user={user} modalProps={props} />);
+}

src/plugins/editUsers/styles.css

@@ -0,0 +1,14 @@
+.vc-editUsers-modal {
+    padding: 1em 0;
+}
+
+.vc-editUsers-tabBar {
+    gap: 1em;
+    margin-bottom: 16px;
+    border-bottom: 2px solid var(--background-modifier-accent);
+}
+
+.vc-editUsers-tab {
+    padding-bottom: 8px;
+}
+

src/plugins/experiments/index.tsx

@@ -23,12 +23,13 @@ import { ErrorCard } from "@components/ErrorCard";
 import { Devs } from "@utils/constants";
 import { Margins } from "@utils/margins";
 import definePlugin, { OptionType } from "@utils/types";
-import { findByPropsLazy } from "@webpack";
+import { findByPropsLazy, findLazy } from "@webpack";
 import { Forms, React } from "@webpack/common";
 
 import hideBugReport from "./hideBugReport.css?managed";
 
 const KbdStyles = findByPropsLazy("key", "combo");
+const BugReporterExperiment = findLazy(m => m?.definition?.id === "2024-09_bug_reporter");
 
 const settings = definePluginSettings({
     toolbarDevMenu: {
@@ -78,8 +79,8 @@ export default definePlugin({
         {
             find: "toolbar:function",
             replacement: {
-                match: /\i\.isStaff\(\)/,
-                replace: "true"
+                match: /hasBugReporterAccess:(\i)/,
+                replace: "_hasBugReporterAccess:$1=true"
             },
             predicate: () => settings.store.toolbarDevMenu
         },
@@ -91,10 +92,18 @@ export default definePlugin({
                 match: /\i\.isDM\(\)\|\|\i\.isThread\(\)/,
                 replace: "false",
             }
+        },
+        // enable option to always record clips even if you are not streaming
+        {
+            find: "isDecoupledGameClippingEnabled(){",
+            replacement: {
+                match: /\i\.isStaff\(\)/,
+                replace: "true"
+            }
         }
     ],
 
-    start: () => enableStyle(hideBugReport),
+    start: () => !BugReporterExperiment.getCurrentConfig().hasBugReporterAccess && enableStyle(hideBugReport),
     stop: () => disableStyle(hideBugReport),
 
     settingsAboutComponent: () => {

src/plugins/reviewDB/index.tsx

@@ -91,7 +91,7 @@ export default definePlugin({
             }
         },
         {
-            find: ".PANEL,isInteractionSource:",
+            find: ".PANEL,interactionType:",
             replacement: {
                 match: /{profileType:\i\.\i\.PANEL,children:\[/,
                 replace: "$&$self.BiteSizeReviewsButton({user:arguments[0].user}),"

src/webpack/common/types/menu.d.ts

@@ -72,6 +72,11 @@ export interface Menu {
         onChange(value: number): void,
         renderValue?(value: number): string,
     }>;
+    MenuSearchControl: RC<{
+        query: string
+        onChange(query: string): void;
+        placeholder?: string;
+    }>;
 }
 
 export interface ContextMenuApi {